try to fix fd issues

This commit is contained in:
cy 2025-04-26 18:21:49 -04:00
parent 0fae7ac3b0
commit 0fedae9334
Signed by: cy
SSH key fingerprint: SHA256:o/geVWV4om1QhUSkKvDQeW/eAihwnjyXkqMwrVdbuts
3 changed files with 40 additions and 17 deletions

View file

@ -6,19 +6,20 @@ use nix_compat::{
};
use sha2::{Digest, Sha256};
use std::mem::take;
use tempfile::NamedTempFile;
use tempfile::{NamedTempFile, TempPath};
use tokio::{
fs::File,
io::{AsyncRead, BufReader},
process::Command,
};
use tokio_util::io::InspectReader;
use tracing::debug;
use crate::path_info::PathInfo;
pub struct MakeNar<'a> {
path_info: &'a PathInfo,
nar_file: NamedTempFile,
nar_file: TempPath,
nar_hasher: Sha256,
/// hash of compressed nar file
file_hasher: Sha256,
@ -30,7 +31,9 @@ impl<'a> MakeNar<'a> {
pub fn new(path_info: &'a PathInfo) -> Result<Self> {
Ok(Self {
path_info,
nar_file: NamedTempFile::new().context("crated tempfile for nar")?,
nar_file: NamedTempFile::new()
.context("create tempfile for nar")?
.into_temp_path(),
nar_hasher: Sha256::new(),
file_hasher: Sha256::new(),
nar_size: 0,
@ -39,12 +42,19 @@ impl<'a> MakeNar<'a> {
}
pub async fn make(&self) -> Result<()> {
let path = self.path_info.absolute_path();
let out = std::fs::File::options()
.write(true)
.truncate(true)
.open(&self.nar_file)?;
debug!("dumping nar for: {}", path);
Ok(Command::new("nix")
.arg("nar")
.arg("dump-path")
.arg("pack")
.arg(self.path_info.absolute_path())
.kill_on_drop(true)
.stdout(self.nar_file.reopen()?)
.stdout(out)
.spawn()?
.wait()
.await?
@ -54,22 +64,30 @@ impl<'a> MakeNar<'a> {
/// Returns a compressed nar reader which can be uploaded. File hash will be available when
/// everything is read
pub async fn compress_and_hash(&mut self) -> Result<impl AsyncRead> {
let nar_file = File::from_std(self.nar_file.reopen()?);
let nar_file = File::open(&self.nar_file).await?;
// reader that hashes as nar is read
let nar_reader = InspectReader::new(nar_file, |x| self.nar_hasher.update(x));
let nar_reader = InspectReader::new(nar_file, |x| {
self.nar_size += x.len() as u64;
self.nar_hasher.update(x);
});
let encoder = ZstdEncoder::with_quality(BufReader::new(nar_reader), Level::Default);
// reader that updates file_hash as the compressed nar is read
Ok(InspectReader::new(encoder, |x| self.file_hasher.update(x)))
Ok(InspectReader::new(encoder, |x| {
self.file_size += x.len() as u64;
self.file_hasher.update(x);
}))
}
/// Returns *unsigned* narinfo. `url` must be updated before uploading
pub fn get_narinfo(&mut self) -> Result<NarInfo> {
let file_hash = take(&mut self.file_hasher).finalize().into();
let nar_hash = take(&mut self.nar_hasher).finalize().into();
Ok(NarInfo {
flags: narinfo::Flags::empty(),
store_path: self.path_info.path.as_ref(),
nar_hash: take(&mut self.nar_hasher).finalize().into(),
nar_hash,
nar_size: self.nar_size,
references: self
.path_info