refactor and bunch more improvements; use object_store for s3
This commit is contained in:
parent
b1e59d0a6c
commit
81ce855dae
9 changed files with 535 additions and 1320 deletions
217
src/uploader.rs
217
src/uploader.rs
|
@ -1,190 +1,75 @@
|
|||
use anyhow::Result;
|
||||
use async_compression::{Level, tokio::bufread::ZstdEncoder};
|
||||
use aws_sdk_s3::{
|
||||
self as s3,
|
||||
types::{CompletedMultipartUpload, CompletedPart},
|
||||
};
|
||||
use futures::future::join_all;
|
||||
use nix_compat::{
|
||||
narinfo::{self, NarInfo, SigningKey},
|
||||
nixbase32,
|
||||
store_path::StorePath,
|
||||
};
|
||||
use sha2::{Digest, Sha256};
|
||||
use tokio::{io::AsyncReadExt, process::Command};
|
||||
use tracing::debug;
|
||||
use bytes::BytesMut;
|
||||
use nix_compat::{narinfo::SigningKey, nixbase32};
|
||||
use object_store::{ObjectStore, aws::AmazonS3, buffered::BufWriter, path::Path};
|
||||
use std::sync::Arc;
|
||||
use tokio::io::{AsyncReadExt, AsyncWriteExt};
|
||||
use tracing::{debug, trace};
|
||||
use ulid::Ulid;
|
||||
|
||||
use crate::path_info::PathInfo;
|
||||
use crate::{make_nar::MakeNar, path_info::PathInfo};
|
||||
|
||||
const MULTIPART_CUTOFF: usize = 1024 * 1024 * 5;
|
||||
const CHUNK_SIZE: usize = 1024 * 1024 * 5;
|
||||
|
||||
pub struct Uploader<'a> {
|
||||
signing_key: &'a SigningKey<ed25519_dalek::SigningKey>,
|
||||
path: PathInfo,
|
||||
s3_client: &'a s3::Client,
|
||||
bucket: String,
|
||||
hash: Sha256,
|
||||
}
|
||||
|
||||
impl<'a> Uploader<'a> {
|
||||
pub fn new(
|
||||
signing_key: &'a SigningKey<ed25519_dalek::SigningKey>,
|
||||
path: PathInfo,
|
||||
s3_client: &'a s3::Client,
|
||||
bucket: String,
|
||||
) -> Result<Self> {
|
||||
Ok(Self {
|
||||
signing_key,
|
||||
path,
|
||||
s3_client,
|
||||
bucket,
|
||||
hash: Sha256::new(),
|
||||
})
|
||||
Ok(Self { signing_key, path })
|
||||
}
|
||||
|
||||
pub async fn upload(&self) -> Result<()> {
|
||||
let nar = self.make_nar().await?;
|
||||
let mut nar_info = self.narinfo_from_nar(&nar)?;
|
||||
let nar = self.compress_nar(&nar).await;
|
||||
pub async fn upload(&self, s3: Arc<AmazonS3>) -> Result<()> {
|
||||
let mut nar = MakeNar::new(&self.path)?;
|
||||
nar.make().await?;
|
||||
|
||||
// update fields that we know after compression
|
||||
let mut hasher = Sha256::new();
|
||||
hasher.update(&nar);
|
||||
let hash: [u8; 32] = hasher.finalize().into();
|
||||
let nar_url = self.nar_url(&hash);
|
||||
nar_info.file_hash = Some(hash);
|
||||
nar_info.file_size = Some(nar.len() as u64);
|
||||
nar_info.url = nar_url.as_str();
|
||||
debug!("uploading nar with key: {nar_url}");
|
||||
// we don't know what the hash of the compressed file will be so upload to a
|
||||
// temp location for now
|
||||
let temp_path = Path::parse(Ulid::new().to_string())?;
|
||||
let mut s3_writer = BufWriter::new(s3.clone(), temp_path.clone());
|
||||
|
||||
if nar.len() < MULTIPART_CUTOFF {
|
||||
let put_object = self
|
||||
.s3_client
|
||||
.put_object()
|
||||
.bucket(&self.bucket)
|
||||
.key(&nar_url)
|
||||
.body(nar.into())
|
||||
.send()
|
||||
.await?;
|
||||
debug!("put object: {:#?}", put_object);
|
||||
} else {
|
||||
let multipart = self
|
||||
.s3_client
|
||||
.create_multipart_upload()
|
||||
.bucket(&self.bucket)
|
||||
.key(&nar_url)
|
||||
.send()
|
||||
.await?;
|
||||
let upload_id = multipart.upload_id().unwrap();
|
||||
|
||||
let mut parts = Vec::with_capacity(nar.len() / MULTIPART_CUTOFF);
|
||||
let chunks = nar.chunks(MULTIPART_CUTOFF);
|
||||
for (i, chunk) in chunks.enumerate() {
|
||||
parts.push(tokio::task::spawn(
|
||||
self.s3_client
|
||||
.upload_part()
|
||||
.bucket(&self.bucket)
|
||||
.key(&nar_url)
|
||||
.upload_id(upload_id)
|
||||
.part_number(i as i32 + 1)
|
||||
.body(chunk.to_vec().into())
|
||||
.send(),
|
||||
));
|
||||
}
|
||||
|
||||
let completed_parts = join_all(parts)
|
||||
.await
|
||||
.into_iter()
|
||||
.flatten()
|
||||
.collect::<Result<Vec<_>, _>>()?
|
||||
.into_iter()
|
||||
.enumerate()
|
||||
.map(|(i, part)| {
|
||||
CompletedPart::builder()
|
||||
.set_e_tag(part.e_tag().map(ToString::to_string))
|
||||
.set_part_number(Some(i as i32 + 1))
|
||||
.set_checksum_sha256(part.checksum_sha256().map(ToString::to_string))
|
||||
.build()
|
||||
})
|
||||
.collect::<Vec<_>>();
|
||||
|
||||
let completed_mp_upload = CompletedMultipartUpload::builder()
|
||||
.set_parts(Some(completed_parts))
|
||||
.build();
|
||||
|
||||
let complete_mp_upload = self
|
||||
.s3_client
|
||||
.complete_multipart_upload()
|
||||
.bucket(&self.bucket)
|
||||
.key(&nar_url)
|
||||
.upload_id(upload_id)
|
||||
.multipart_upload(completed_mp_upload)
|
||||
.send()
|
||||
.await?;
|
||||
|
||||
debug!("complete multipart upload: {:#?}", complete_mp_upload);
|
||||
// compress and upload nar
|
||||
let mut file_reader = nar.compress_and_hash().await?;
|
||||
let mut buf = BytesMut::with_capacity(CHUNK_SIZE);
|
||||
debug!("uploading to temp path: {}", temp_path);
|
||||
while let n = file_reader.read_buf(&mut buf).await?
|
||||
&& n != 0
|
||||
{
|
||||
s3_writer.write_all_buf(&mut buf).await?;
|
||||
}
|
||||
drop(file_reader);
|
||||
|
||||
let narinfo_url = format!("{}.narinfo", self.path.digest());
|
||||
debug!("uploading narinfo with key {narinfo_url}");
|
||||
self.s3_client
|
||||
.put_object()
|
||||
.bucket(&self.bucket)
|
||||
.key(narinfo_url)
|
||||
.body(nar_info.to_string().as_bytes().to_vec().into())
|
||||
.send()
|
||||
.await?;
|
||||
debug!("done uploading narinfo");
|
||||
let mut nar_info = nar.get_narinfo()?;
|
||||
nar_info.add_signature(self.signing_key);
|
||||
trace!("narinfo: {:#}", nar_info);
|
||||
|
||||
// now that we can calculate the file_hash move the nar to where it should be
|
||||
let real_path = nar_url(
|
||||
&nar_info
|
||||
.file_hash
|
||||
.expect("file hash must be known at this point"),
|
||||
);
|
||||
debug!("moving {} to {}", temp_path, real_path);
|
||||
// this is implemented as a copy-and-delete
|
||||
s3.rename(&temp_path, &real_path).await?;
|
||||
|
||||
// upload narinfo
|
||||
let narinfo_path = self.path.narinfo_path();
|
||||
debug!("uploading narinfo: {}", narinfo_path);
|
||||
s3.put(&narinfo_path, nar_info.to_string().into()).await?;
|
||||
|
||||
Ok(())
|
||||
}
|
||||
|
||||
async fn make_nar(&self) -> Result<Vec<u8>> {
|
||||
Ok(Command::new("nix")
|
||||
.arg("nar")
|
||||
.arg("dump-path")
|
||||
.arg(self.path.absolute_path())
|
||||
.output()
|
||||
.await?
|
||||
.stdout)
|
||||
}
|
||||
|
||||
fn narinfo_from_nar(&self, nar: &[u8]) -> Result<NarInfo> {
|
||||
let mut hasher = Sha256::new();
|
||||
hasher.update(nar);
|
||||
let nar_hash: [u8; 32] = hasher.finalize().into();
|
||||
let mut nar_info = NarInfo {
|
||||
flags: narinfo::Flags::empty(),
|
||||
store_path: self.path.path.as_ref(),
|
||||
nar_hash,
|
||||
nar_size: nar.len() as u64,
|
||||
references: self.path.references.iter().map(StorePath::as_ref).collect(),
|
||||
signatures: Vec::new(),
|
||||
ca: None,
|
||||
system: None,
|
||||
deriver: None,
|
||||
compression: Some("zstd"),
|
||||
file_hash: None,
|
||||
file_size: None,
|
||||
url: "",
|
||||
};
|
||||
// signature consists of: store_path, nar_hash, nar_size, and references
|
||||
nar_info.add_signature(self.signing_key);
|
||||
Ok(nar_info)
|
||||
}
|
||||
|
||||
fn nar_url(&self, compressed_nar_hash: &[u8]) -> String {
|
||||
let compressed_nar_hash = nixbase32::encode(compressed_nar_hash);
|
||||
format!("nar/{compressed_nar_hash}.nar.zst")
|
||||
}
|
||||
|
||||
async fn compress_nar(&self, nar: &[u8]) -> Vec<u8> {
|
||||
let mut encoder = ZstdEncoder::with_quality(nar, Level::Default);
|
||||
let mut compressed = Vec::with_capacity(nar.len());
|
||||
encoder
|
||||
.read_to_end(&mut compressed)
|
||||
.await
|
||||
.expect("should compress just fine");
|
||||
compressed
|
||||
}
|
||||
}
|
||||
|
||||
/// calculate url where the compressed nar should be uploaded
|
||||
fn nar_url(file_hash: &[u8]) -> Path {
|
||||
let compressed_nar_hash = nixbase32::encode(file_hash);
|
||||
Path::parse(format!("nar/{compressed_nar_hash}.nar.zst"))
|
||||
.expect("should parse to a valid object_store::path::Path")
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue